Paths

Table of Contentst

Differential D2913

templates/homepage: Fix counters display when storage is empty
ClosedPublic
Actions

Authored by anlambert on Mar 27 2020, 4:11 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDWAPPSf8ac17e10778: templates/homepage: Fix counters display when storage is empty

Summary

This is a simple fix for the counters display in the webapp homepage.

When the storage is empty (for instance after booting the docker env), the
/api/1/stat/counters endpoint returns an empty dict.

So handle that corner case to avoid a JavaScript error when homepage is loading.

Diff Detail

Repository

rDWAPPS Web applications

Branch

homepage-counters-display-fix

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 11455
Build 17363: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 17362: Cypress tests for swh-web diffs	Jenkins
Build 17361: arc lint + arc unit

Event Timeline

anlambert created this revision.Mar 27 2020, 4:11 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 27 2020, 4:11 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/1041/ for more details.

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/654/ for more details.

Harbormaster completed remote builds in B11426: Diff 10347.Mar 27 2020, 4:23 PM

Could you add a test for this? (eg. using Cypress to mock calls to the counter API)

This revision now requires changes to proceed.Mar 27 2020, 5:07 PM

Update: Add cypress test

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/657/ for more details.

Harbormaster failed remote builds in B11455: Diff 10380!Mar 30 2020, 5:40 PM

Build has FAILED

Patch application report for D2913 (id=10380)

Rebasing onto d4446bcac7...

Current branch diff-target is up to date.

Changes applied before test

commit e0e2f4f7ea0ca54770b6fc0fa99bfb378c520c63
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Mar 27 15:02:44 2020 +0100

    templates/homepage: Fix counters display when storage is empty

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/11/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/11/console

Build is green

Patch application report for D2913 (id=10380)

Rebasing onto d4446bcac7...

Current branch diff-target is up to date.

Changes applied before test

commit e0e2f4f7ea0ca54770b6fc0fa99bfb378c520c63
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Mar 27 15:02:44 2020 +0100

    templates/homepage: Fix counters display when storage is empty

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/12/ for more details.

Harbormaster completed remote builds in B11455: Diff 10380.Mar 30 2020, 6:03 PM

Build is green

Patch application report for D2913 (id=10380)

Rebasing onto d4446bcac7...

Current branch diff-target is up to date.

Changes applied before test

commit e0e2f4f7ea0ca54770b6fc0fa99bfb378c520c63
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Mar 27 15:02:44 2020 +0100

    templates/homepage: Fix counters display when storage is empty

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/15/ for more details.

vlorentz accepted this revision.Mar 31 2020, 10:11 AM

This revision is now accepted and ready to land.Mar 31 2020, 10:11 AM

Rebase

Build is green

Patch application report for D2913 (id=10407)

Rebasing onto 9aa7f44e81...

Current branch diff-target is up to date.

Changes applied before test

commit f8ac17e10778b028aa794a4a4a1935e857d46406
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Mar 27 15:02:44 2020 +0100

    templates/homepage: Fix counters display when storage is empty

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/22/ for more details.

Harbormaster completed remote builds in B11482: Diff 10407.Mar 31 2020, 12:04 PM

Closed by commit rDWAPPSf8ac17e10778: templates/homepage: Fix counters display when storage is empty (authored by anlambert). · Explain WhyMar 31 2020, 12:09 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPSf8ac17e10778: templates/homepage: Fix counters display when storage is empty.