Page MenuHomeSoftware Heritage

Make the vault's scheduler configuration adjustable
ClosedPublic

Authored by ardumont on May 3 2018, 3:54 PM.

Details

Summary

Use the scheduler's api instantiation

Not urgent

This can be merged at some point, when you are done with your current tasks for example ;)

Related T1035

Diff Detail

Repository
rDVAU Software Heritage Vault
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1213
Build 1557: arc lint + arc unit

Event Timeline

LGTM, I just have one nitpick on the default configuration that we might want to fix before merging this.

swh/vault/api/server.py
44

Aren't the default usually the remote services, and not the local ones?

This revision is now accepted and ready to land.May 4 2018, 2:22 PM
swh/vault/api/server.py
44

I kept your default because i did not want to impose anything.
Running this by default, you would need to either run a scheduler service (or edit/add a ~/.config/swh/vault/server.yml with the local setup).

But sure, we can use the remote one.
That's what i did for the deposit [1].

[1] rDDEP7e535ab1c196fdeab8722ef610ca1d02ceadbc58

swh/vault/api/server.py
44

Also, i'm matching the other default configuration of that very same file.
No other entry in the default configuration is using any remote service ;)

Amend the prior commit to fix and use the remote scheduler configuration

This revision now requires review to proceed.Jul 18 2018, 2:50 PM
swh/vault/api/server.py
44

Ok, so i had a remark about this on D372#inline-1828 that goes your way.
So fixing this.

Cheers,

  • api/server: Use remote service for default configuration storage

LGTM, I just have one nitpick on the default configuration that we might want to fix before merging this.

Fixed for the scheduler in the amended commit.
Fixed in the second commit for the storage part.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 1 2018, 3:23 PM
This revision was automatically updated to reflect the committed changes.