Differential D2878

assets/utils: Validate sub-projects in isGitRepoUrl function
ClosedPublic
Actions

Authored by anlambert on Mar 25 2020, 5:11 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDWAPPSdc89829a02eb: assets/utils: Validate sub-projects in isGitRepoUrl function

Summary

Previously URL of type https://forge.example.org/user/project/sub-project/ were
not validated by the isGitRepoUrl function.

Related to T2331

Diff Detail

Repository

rDWAPPS Web applications

Branch

assets-fix-isgitrepourl

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 11333
Build 17147: Cypress tests for swh-web diffs	Jenkins
Build 17146: tox-on-jenkins	Jenkins
Build 17145: arc lint + arc unit

Event Timeline

anlambert created this revision.Mar 25 2020, 5:11 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 25 2020, 5:11 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/1034/ for more details.

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/644/ for more details.

Harbormaster completed remote builds in B11333: Diff 10255.Mar 25 2020, 5:21 PM

ardumont accepted this revision.Mar 25 2020, 6:02 PM

This revision is now accepted and ready to land.Mar 25 2020, 6:02 PM

Closed by commit rDWAPPSdc89829a02eb: assets/utils: Validate sub-projects in isGitRepoUrl function (authored by anlambert). · Explain WhyMar 25 2020, 6:05 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPSdc89829a02eb: assets/utils: Validate sub-projects in isGitRepoUrl function.

Revision Contents
Changeset List

Path

Size

cypress/

integration/

origin-save.spec.js

15 lines

swh/

web/

assets/

src/

utils/

functions.js

4 lines

Diff 10255

View Options

cypress/integration/origin-save.spec.js