replayer: factor out legacy objects fixers
ClosedPublic
Actions

Authored by seirl on Mar 23 2020, 6:00 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDJNL099d8190ab24: replayer: factor out legacy objects fixers

Summary

This will allow other journal clients to use the fixers, instead of this
being solely a replayer feature.

One could also imagine integrating the fixer directly in the journal so
that the fixes happen transparently for all the users without having to
call the fixer explicitely, and this diff is a first step in this
direction.

Test Plan

tox passes the unit tests and mypy is happy

Diff Detail

Repository

rDJNL Journal infrastructure

Branch

separate_fixer

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 11299
Build 17086: tox-on-jenkins	Jenkins
Build 17085: arc lint + arc unit

Event Timeline

seirl created this revision.Mar 23 2020, 6:00 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 23 2020, 6:00 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/409/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/409/console

Harbormaster failed remote builds in B11293: Diff 10218!Mar 23 2020, 6:05 PM

Looks good to me, save from one inline comment.

The tests failure is a silly doctest dict key order thing. Even if it's a bit overkill, might I suggest turning the doctests into actual tests that wouldn't exhibit such an issue (in a followup diff)?