Maniphest T3840

"'NoneType' object has no attribute 'split'" on /browse/snapshot/log/
Closed, MigratedEdits Locked
Actions

Assigned To

gitlab-migration

Authored By

	vlorentz
	Jan 10 2022, 1:21 PM

Tags

Subscribers

gitlab-migration

Description

go to https://archive.softwareheritage.org/browse/snapshot/669100e5754a91c1e9b61626bb8e2de2a5bbee05/directory/
click "History" (or go to https://archive.softwareheritage.org/browse/snapshot/669100e5754a91c1e9b61626bb8e2de2a5bbee05/log/ directly)
you get this error: AttributeError: 'NoneType' object has no attribute 'split'

Sentry issue: SWH-WEBAPP-3H7

Revisions and Commits

rDWAPPS Web applications
	D6899	rDWAPPS835a86012630 browse/snapshot_context: Fix revision_found setting in directory view
	D6898	rDWAPPS4ddf1b5598dc browse/snapshot_context: Handle empty revisions history in log view

Event Timeline

vlorentz triaged this task as Normal priority.Jan 10 2022, 1:21 PM

vlorentz created this task.

Ah right, we now have snapshots that only contain releases targeting directories only (typically those generated by the package loaders).

So this type of snapshot do not have a commit log, I guess we should hide the "History" button in that case and handle the empty log in the view.

anlambert added a revision: D6898: browse/snapshot_context: Handle empty revisions history in log view.Jan 10 2022, 3:45 PM

oh thanks, I couldn't figure out why it happened on that particular snapshot

anlambert added a revision: D6899: browse/snapshot_context: Fix revision_found setting in directory view.Jan 10 2022, 4:40 PM

anlambert added a commit: rDWAPPS4ddf1b5598dc: browse/snapshot_context: Handle empty revisions history in log view.Jan 10 2022, 5:24 PM

anlambert added a commit: rDWAPPS835a86012630: browse/snapshot_context: Fix revision_found setting in directory view.

Fixed and deployed.

This task has been migrated to GitLab.