Page MenuHomeSoftware Heritage

Top level tabs not working in snapshot view
Open, NormalPublic

Description

https://archive.softwareheritage.org/browse/snapshot/dc98316fd78351ba815adaa8731417473ed8d2f9/branches/

Clicking on Branches or releases changes the content. But the top tab always stays in code.

update: It is not possible to change back to the code tab (neither content nor tab) from branches and resales tab.

Event Timeline

jayeshv triaged this task as Normal priority.Mon, Oct 11, 9:26 AM
jayeshv created this task.
jayeshv updated the task description. (Show Details)

Looks like the bug comes from that piece of javascript code. We should test if the pathname ends with /branches/ or /releases/ instead to activate the correct tab.

Looks like the bug comes from that piece of javascript code. We should test if the pathname ends with /branches/ or /releases/ instead to activate the correct tab.

No, there is an issue in the python code as well.
https://forge.softwareheritage.org/source/swh-web/browse/master/swh/web/templates/includes/snapshot-context.html$40
snapshot_context.visit_info is None, when we access this page without an origin.

I mean, no visit_info set in this else
https://forge.softwareheritage.org/source/swh-web/browse/master/swh/web/browse/snapshot_context.py$488

Js bug is only about changing tabs.