Page MenuHomeSoftware Heritage

FUSE: add an unmount command
Closed, MigratedEdits Locked

Description

We need a user story which is better than killall python for unmouonting the FUSE VFS when swh fuse mount has not been invoked with --foreground.
(Unless FUSE has a general solution for this? does /usr/bin/umount just work out of the box on a FUSE mount point, maybe? I couldn't experimentally determine this at the moment due to T2699.)

The most straightforward why to go about this would be adding a swh fuse umount command. And we can store PID information about the FUSE daemon to kill in a virtual PID file within the mount point itself.

Event Timeline

zack triaged this task as Low priority.Oct 14 2020, 11:53 AM
zack created this task.

To unmount you can use fusermount -u /mntdir

as @haltode suggests, that's how i unmount my sshfs mount point for example.

To unmount you can use fusermount -u /mntdir

OK, great to know!

So the question is whether we want to proxy that with an explicit swh fuse umount command, or just document it somewhere.
(I expect that most swh-fuse users will not know how to unmount a FUSE VFS, so we want something at the very least.)

I think we should add a full example of using (+ unmounting) the FUSE VFS in the tutorial doc (T2676), and not an extra umount command.

We can't expect all users to read the tutorial, that just doesn't happen in the real world :-)
If we don't add an explicit umount command, we should at least document how to unmount also in the doc of the mount command

Also: what are the cons of adding a umount command with just wraps fusermount -u?

Edit: OK, here is the killer argument for an umount command:

$ swh fuse mount swhfs/
$ # hack hack hack
$ # arrow up or Ctrl-R ; add a single 'u' letter
$ swh fuse umount swhfs/

*priceless* in comparison to having to type (not to mention remember) a full fusermount -u swhfs/ :-)

zack changed the task status from Open to Work in Progress.Oct 16 2020, 5:54 PM
zack moved this task from Backlog to In progress on the Software Heritage filesystem board.