Page MenuHomeSoftware Heritage

Add validation step after metadata ingestion of a metadata-only deposit
Closed, MigratedEdits Locked

Description

Verifying that the metadata that were sent to the ERMDS are effectively the ones you get when calling the get on the same SWHID.

Implementation wise, this reading step is currently done in the deposit test [1] but not in the runtime code [2].
The idea would be to add that reading step in the runtime code.

[1] https://forge.softwareheritage.org/source/swh-deposit/browse/master/swh/deposit/tests/api/test_deposit_update.py$666-669
[2] https://forge.softwareheritage.org/source/swh-deposit/browse/master/swh/deposit/api/deposit_update.py$264-278

Event Timeline

moranegg triaged this task as Normal priority.Oct 9 2020, 3:05 PM
moranegg created this task.

We decided to put this aside for the moment.

The SWHID is calculated on the loader and isn't a guarantee of insertion in the storage.
Checking this for metadata is diverging from what's done with a classic deposit.

moranegg lowered the priority of this task from Normal to Low.Nov 3 2020, 12:11 PM