Page MenuHomeSoftware Heritage
Create Task
Maniphest T2641

Fix SWHID resolving when origin qualifier has an equal character in its value
Closed, MigratedEdits Locked
Actions

Description

I have stumbled upon this permalink which I get when I click copy permalink:

https://archive.softwareheritage.org/swh:1:dir:53ddae53e380c56cf74dd9ad06be87e1f83fa450;origin=https://cran.r-project.org/package%3DActivePathways;visit=swh:1:snp:9b706ec3d79576d295fca2980c546d6b760ffc54;anchor=swh:1:rev:191039b4497ec53153e480cacfa1df9b46b38e6e;path=/ActivePathways//

It yields a 404 error when used.

This does not happen with copy identifier:

swh:1:dir:53ddae53e380c56cf74dd9ad06be87e1f83fa450;origin=https://cran.r-project.org/package%3DActivePathways;visit=swh:1:snp:9b706ec3d79576d295fca2980c546d6b760ffc54;anchor=swh:1:rev:191039b4497ec53153e480cacfa1df9b46b38e6e;path=/ActivePathways/

Revisions and Commits

rDWAPPS Web applications
D4035rDWAPPS1d48edfb2eba SWHIDs: Fix URLs escaping when a qualifier contains escaped chars

Event Timeline

moranegg triaged this task as High priority.Sep 24 2020, 11:16 AM
moranegg created this task.
anlambert added a comment.Sep 24 2020, 11:29 AM

The issue is not related to the double slash at the end of the permalink but rather from the fact that the origin URL contains a = character in it (https://archive.softwareheritage.org/browse/origin/directory/?origin_url=https://cran.r-project.org/package%3DActivePathways). I will fix that asap.

anlambert renamed this task from Fix permalink with double // at the end to Fix SWHID resolving when origin qualifier has an equal character in its value.Sep 24 2020, 11:30 AM
moranegg added a comment.Sep 24 2020, 11:39 AM

Thanks for checking !

anlambert added a comment.Sep 24 2020, 12:22 PM

Hopefully, the issue is related to missing URL escaping in the webapp. I implemented the fix, still some tests to write and I will push a diff during the afternoon.

anlambert added a revision: D4035: SWHIDs: Fix URLs escaping when a qualifier contains escaped chars.Sep 24 2020, 5:39 PM
anlambert closed this task as Resolved by committing rDWAPPS1d48edfb2eba: SWHIDs: Fix URLs escaping when a qualifier contains escaped chars.Sep 24 2020, 7:24 PM
anlambert added a commit: rDWAPPS1d48edfb2eba: SWHIDs: Fix URLs escaping when a qualifier contains escaped chars.
gitlab-migration changed the task status from Resolved to Migrated.Jan 8 2023, 4:31 PM
gitlab-migration claimed this task.
gitlab-migration added subscribers: anlambert, gitlab-migration.

This task has been migrated to GitLab.

About · Developer information · Legal