Page MenuHomeSoftware Heritage

web app: archive search broken for SWHIDs
Closed, MigratedEdits Locked

Description

when entering a PID in the search box (which we declare supported: "Enter a persistent id to resolve or"), e.g., swh:1:cnt:94a9ed024d3859793618152ea559a168bbcbb5e2, the result is the error string: 'PersistentId' object has no attribute '_asdict'

(thanks @zvr for the bug report)

Event Timeline

zack triaged this task as High priority.Jul 27 2020, 4:28 PM
zack created this task.

It's most probably a new swh-web version not released yet.

There is no longer a reference to that _asdict call currently.
And the next commit 423ac846 following the current deployed version v0.0.245 has some asdict reference in the removed part of the commit.

I need to deploy new modules version tomorrow (including the webapp) so i'll double check.

Cheers,

ardumont changed the task status from Open to Work in Progress.Jul 28 2020, 9:00 AM

Actually tagging/releasing modules so yeah wip.

staging webapp does not entertain that behavior [1] So i'm hopeful the new
deployment i'm going to make will fix it ;)

[1] note that i forgot to check prior to deploy it there though ¯\_(ツ)_/¯

ardumont claimed this task.

staging webapp does not entertain that behavior [1] So i'm hopeful the new
deployment i'm going to make will fix it ;)

Yes, fixed.