Page MenuHomeSoftware Heritage

Web API: more user friendly answer when checking state of non existent save code now requests
Closed, ResolvedPublic

Description

GET on a save code now request for an unknown URL currently returns "nothing" (or, better, an empty list). That is quite puzzling.
If possible, we should return an error message like "unknown save code now request" or something such.

$ curl -D - https://archive.softwareheritage.org/api/1/origin/save/git/url/https://example.com/foo/bar/baz/
HTTP/1.1 200 OK
Date: Tue, 16 Apr 2019 17:08:49 GMT
Server: gunicorn/19.9.0
X-RateLimit-Limit: 120
X-Frame-Options: SAMEORIGIN
Content-Type: application/json
Allow: GET, OPTIONS, POST
X-RateLimit-Reset: 1555434559
Expires: Tue, 16 Apr 2019 17:08:49 GMT
Cache-Control: no-store, max-age=0, must-revalidate, no-cache
X-RateLimit-Remaining: 118
Content-Length: 2
Vary: Accept,Cookie
Via: 1.1 archive.softwareheritage.org
Access-Control-Allow-Origin: *
X-Varnish: 39585629
Age: 0
Via: 1.1 varnish (Varnish/5.0)
Strict-Transport-Security: max-age=15768000;
Accept-Ranges: bytes
Connection: keep-alive

[]%

Event Timeline

zack created this task.Apr 16 2019, 7:16 PM
zack triaged this task as Low priority.
anlambert added a subscriber: anlambert.

Indeed, returning a 404 error seems the best option here. Will fix that asap.