Hi

The doc for contributing is here: https://wiki.softwareheritage.org/wiki/Code_review_in_Phabricator

I'll let @anlambert answer your other question

Hi,

Thanks for the contribution! If you could submit us a Phabricator Diff (which is close to GitHub Pull Request)
by following the instructions in the link posted by vlorentz above, I will be glad to integrate it.

Also, I think that the XML file implementing the OpenSearch plugin should be hosted on our web server.
The best option should be to create a xml folder inside swh/web/static/ and put the file here (renamed to swh-opensearch.xml for instance).
You can then reference it in the layout.html template using the following:

<link rel="search" type="application/opensearchdescription+xml" title="Software Heritage archive of public source code" href="{% static 'xml/swh-opensearch.xml' %}">

Thanks for the advice :-) With this Arcanist, they were indeed needed.

I felt compelled to use arc diff --skip-staging origin/master to overcome an error the wiki doesn't seem to mention:

git@forge.softwareheritage.org: Permission denied (publickey,keyboard-interactive).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
 STAGING FAILED  Unable to push changes to the staging area.

If that's a standard flag used around here, please let me know and I'll add it to the wiki.

@katrinleinweber Thanks for the contribution!

I felt compelled to use arc diff --skip-staging origin/master to overcome an error the wiki doesn't seem to mention:
If that's a standard flag used around here, please let me know and I'll add it to the wiki.

Not that i'm aware of.

Thanks for mentioning that issue as well.
I've opened T1522 to determine what we want to do with the staging area.
In the mean time, feel free to continue diffing with that flag.

@katrinleinweber jsyk, our staging area setup and documentation [1] [2] have been updated accordingly (rationale is at T1522).

[1] diff since you read: https://wiki.softwareheritage.org/index.php?title=Code_review_in_Phabricator&type=revision&diff=964&oldid=899

[2] raw documentation: https://wiki.softwareheritage.org/index.php?title=Code_review_in_Phabricator