Paths

Table of Contentst

Differential D962

Rewrite archiver's tasks and unit tests with latest scheduler's "API"
ClosedPublic
Actions

Authored by douardda on Jan 16 2019, 1:36 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Maniphest Tasks

T1480: Refactor tasks code as decorated functions using swh-scheduler 0.0.39
T1476: Update archiver to new scheduler's tasks

Commits

rDARC0a9278f14160: Rewrite archiver's tasks and unit tests with latest scheduler's "API"

Summary

Closes T1476

Diff Detail

Repository

rDARC Software Heritage Archiver

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Jan 16 2019, 1:36 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 16 2019, 1:36 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DARC/job/tox/22/
See console output for more information: https://jenkins.softwareheritage.org/job/DARC/job/tox/22/console

Harbormaster failed remote builds in B3563: Diff 3057!Jan 16 2019, 1:37 PM

Build is green
See https://jenkins.softwareheritage.org/job/DARC/job/tox/27/ for more details.

douardda added a child revision: D964: update dep on swh-scheduler>0.0.39 and pytest<4 (tests).Jan 16 2019, 4:49 PM

Uses of tempfile.mkdtemp can now be replaced with with tempfile.TemporaryDirectory; that will spare a try...finally.

vlorentz accepted this revision.Jan 16 2019, 6:16 PM

This revision is now accepted and ready to land.Jan 16 2019, 6:16 PM

In D962#20586, @vlorentz wrote:

Uses of tempfile.mkdtemp can now be replaced with with tempfile.TemporaryDirectory; that will spare a try...finally.

I know, but I'm not sure I prefer this since we do need the try/finally to restore the parse_config_file methods. Let's keep it as is for now and refactor it if some more work is needed on these tests.

Closed by commit rDARC0a9278f14160: Rewrite archiver's tasks and unit tests with latest scheduler's "API" (authored by douardda). · Explain WhyJan 17 2019, 9:45 AM

This revision was automatically updated to reflect the committed changes.

douardda mentioned this in T1480: Refactor tasks code as decorated functions using swh-scheduler 0.0.39.Jan 17 2019, 4:28 PM

douardda added a task: T1480: Refactor tasks code as decorated functions using swh-scheduler 0.0.39.

Revision Contents
Changeset List

Path

Size

requirements-test.txt

1 line

swh/

archiver/

31 lines

tests/

151 lines

test_archiver.py

612 lines

test_archiver_storage.py

79 lines

Diff 3063

requirements-test.txt

Loading...

swh/archiver/tasks.py

Loading...

swh/archiver/tests/conftest.py

Loading...

swh/archiver/tests/test_archiver.py

Loading...

swh/archiver/tests/test_archiver_storage.py

Loading...