Details
Diff Detail
- Repository
- rDWAPPS Web applications
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/107/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/107/console
swh/web/api/views/origin.py | ||
---|---|---|
77–80 | You should set origin_count = results[0]['id'] - origin_from` (or something similar) |
swh/web/tests/api/views/test_origin.py | ||
---|---|---|
338–341 | Is this how example() is supposed to be used with hypothesis? It looks like it exepects that "one call of the test function = one example". Shouldn't we ask hypothesis to build a list of origins instead? |
swh/web/api/views/origin.py | ||
---|---|---|
77–80 | There is no need to do so as origin_count corresponds to the maximum number of origins to return. | |
swh/web/tests/api/views/test_origin.py | ||
338–341 | The issue here is that I restrain the maximum number of examples to 1 to speedup overall tests execution. However, I agree that this code could be put in a dedicated strategy function as |
swh/web/api/views/origin.py | ||
---|---|---|
77–80 | I know, but as this is the link-prev, having too many origins will make the two lists of origins overlap. |
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/108/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/108/console
swh/web/api/views/origin.py | ||
---|---|---|
77–80 | Yes it can happen but I don't want to modify the origin_count parameter value. In practice, origins should be listed from the first one to the last one so that's not really |
swh/web/api/views/origin.py | ||
---|---|---|
77–80 | Shouldn't we drop link-prev then? |
swh/web/api/views/origin.py | ||
---|---|---|
77–80 | Sold, will update accordingly after rebase (got some incoming changes in master branch that I want to push before landing that one). |
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/109/ for more details.
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/110/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/110/console
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/111/ for more details.
Thanks for the review @vlorentz . I will address your last comments and land that diff.
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/112/ for more details.