Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Maniphest Tasks
- T1385: Monitor output of metadata indexers
- Commits
- rDCIDX1146b7c854eb: Prevent repository normalization from crashing on malformed input.
Diff Detail
Diff Detail
- Repository
- rDCIDX Metadata indexer
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/213/ for more details.
| swh/indexer/metadata_dictionary.py | ||
|---|---|---|
| 287–296 | I find this code a bit bloated. Is it possible to have something other than a str or None for these values? (url, group and artifact) ? Isn't this code enough? if 'url' not in repo or repo.get('layout', 'default') != 'default':
return
group_id = d.get('groupId', '')
artifact_id = d.get('artifactId', '')
url = os.path.join(repo['url'], group_id.replace('.', '/'), artifact_id)
return {'@id': url}Hard to tell since it seems this method has no unit test 😈 | |
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/217/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/217/console