Drop sessionStorage, only use the URL to store state.
ClosedPublic
Actions

Authored by vlorentz on Jan 11 2019, 1:52 PM.

Details

Reviewers

Group Reviewers

Commits

R65:983d3bdcb480: Drop sessionStorage, only use the URL to store state.
R65:6690362e6730: Remove debug config
rDWAPPS6690362e6730: Remove debug config
rDWAPPS983d3bdcb480: Drop sessionStorage, only use the URL to store state.

Summary

AFAIK, the only noticeable change is that pressing F5 sends a request for the content, instead of using the sessionStorage as cache.

Diff Detail

Repository

rDWAPPS Web applications

Branch

drop-sessionStorage

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 3427
Build 4414: tox-on-jenkins	Jenkins
Build 4413: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jan 11 2019, 1:52 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 11 2019, 1:52 PM

Remove debug config

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/98/ for more details.

Harbormaster completed remote builds in B3427: Diff 2937.Jan 11 2019, 1:54 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/99/ for more details.

Harbormaster completed remote builds in B3428: Diff 2938.Jan 11 2019, 1:57 PM

Originally, I used session storage in order to get the search results back when hitting the 'Search' menu entry again.
But that's not really needed so let's land that diff.

This revision is now accepted and ready to land.Jan 11 2019, 3:10 PM

Closed by commit rDWAPPS983d3bdcb480: Drop sessionStorage, only use the URL to store state. (authored by vlorentz). · Explain WhyJan 11 2019, 3:38 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

web/

assets/

src/

bundles/

browse/

origin-search.js

59 lines

Diff 2937

View Options

swh/web/assets/src/bundles/browse/origin-search.js

Drop sessionStorage, only use the URL to store state.ClosedPublicActions