Remove direct exposition of PathSlicingObjStorage
ClosedPublic
Actions

Authored by qcampos on Aug 4 2016, 4:31 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDOBJS38d4238e391c: Remove direct exposition of PathSlicingObjStorage

Summary

The PathSlicingObjStorage was exposed in the swh.objstorage top-level,
and is no longer a default implementation.
Classes using an ObjStorage should now use the get_objstorage method.

Diff Detail

Repository

rDOBJS Object storage

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

qcampos updated this revision to Diff 307.Aug 4 2016, 4:31 PM

qcampos retitled this revision from to Remove direct exposition of PathSlicingObjStorage.

qcampos updated this object.

qcampos edited the test plan for this revision. (Show Details)

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 4 2016, 4:31 PM

olasd accepted this revision.Aug 4 2016, 4:37 PM

olasd added a reviewer: olasd.

This revision is now accepted and ready to land.Aug 4 2016, 4:37 PM

qcampos added a child revision: D92: Make the content checker easy to extend and add an implementation.Aug 4 2016, 4:38 PM

Note that __all__ only affects the objects that are available when doing from swh.objstorage import *, and that a caller can still explicitly get all the names that are defined in the module.

Closed by commit rDOBJS38d4238e391c: Remove direct exposition of PathSlicingObjStorage (authored by qcampos). · Explain WhyAug 4 2016, 4:39 PM

This revision was automatically updated to reflect the committed changes.

qcampos mentioned this in rDOBJScc35ceaf3a3d: Remove a TODO forgotten in D91.Aug 12 2016, 12:32 PM