Page MenuHomeSoftware Heritage

Remove tool ids from Kafka messages
ClosedPublic

Authored by vlorentz on Dec 7 2022, 2:08 PM.

Details

Summary
  1. they are internal to the DB so they do not belong in Kafka
  2. on unrelated errors, they cause swh.journal to crash because it does not know how to handle integers in the output of unique_key()

Closes T4719

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

Patch application report for D8934 (id=32192)

Rebasing onto f74b47bcf4...

Current branch diff-target is up to date.
Changes applied before test
commit d9806be469102e81621493ce596c1a15680c5a4c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Dec 7 14:06:36 2022 +0100

    Remove tool ids from Kafka messages
    
    1. they are internal to the DB so they do not belong in Kafka
    2. on unrelated errors, they cause swh.journal to crash because it does
       not know how to handle integers in the output of unique_key()

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/535/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/535/console

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 7 2022, 2:12 PM
Harbormaster failed remote builds in B33146: Diff 32192!

Build is green

Patch application report for D8934 (id=32195)

Rebasing onto f74b47bcf4...

Current branch diff-target is up to date.
Changes applied before test
commit e8549400bc547cff769671e945566f5343aa320f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Dec 7 14:06:36 2022 +0100

    Remove tool ids from Kafka messages
    
    1. they are internal to the DB so they do not belong in Kafka
    2. on unrelated errors, they cause swh.journal to crash because it does
       not know how to handle integers in the output of unique_key()

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/536/ for more details.

ardumont added a subscriber: ardumont.

I was sold on the description!

This revision is now accepted and ready to land.Dec 7 2022, 4:20 PM
This revision was automatically updated to reflect the committed changes.