from_disk.Content: Add missing path info for symlink
ClosedPublic
Actions

Authored by anlambert on Dec 5 2022, 4:19 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDMOD818ad826a4f4: from_disk.Content: Add missing path info for symlink

Summary

from_disk.Content object created for a symlink was missing path info
so ensure to add it for consistency with from_disk.Content object
created for a regular file.

Diff Detail

Repository

rDMOD Data model

Branch

from-disk-content-add-symlink-path-info

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 33086
Build 51863: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 51862: arc lint + arc unit

Event Timeline

anlambert created this revision.Dec 5 2022, 4:19 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 5 2022, 4:19 PM

Build is green

Patch application report for D8920 (id=32133)

Rebasing onto fe8d55588a...

Current branch diff-target is up to date.

Changes applied before test

commit 818ad826a4f4db6d7e6c17877ee2ca4c4447e6f8
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Dec 5 16:15:55 2022 +0100

    from_disk.Content: Add missing path info for symlink
    
    from_disk.Content object created for a symlink was missing path info
    so ensure to add it for consistency with from_disk.Content object
    created for a regular file.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/545/ for more details.

Harbormaster completed remote builds in B33086: Diff 32133.Dec 5 2022, 4:21 PM

anlambert requested review of this revision.Dec 5 2022, 4:21 PM

Does it mean we were silently dropping data until this? Which loaders use this?

In D8920#231860, @vlorentz wrote:

Does it mean we were silently dropping data until this? Which loaders use this?

Only for the symlink case, found the issue while debugging subversion loader (see line that triggered error).
Loaders convert from_disk merkle nodes to model objects before sending data to the storage so that's why we did not spot it before.