Instead of manually setting some HTTP headers, prefer to use django
FileResponse class that set those.
It fixes the download of raw files with non ascii filenames.
Fixes SWH-WEBAPP-3YS.
Details
Details
- Reviewers
vlorentz - Group Reviewers
Reviewers - Maniphest Tasks
- Restricted Maniphest Task
- Commits
- rDWAPPSad8558c69d88: browse: Use django FileResponse in browse-content-raw view
Diff Detail
Diff Detail
- Repository
- rDWAPPS Web applications
- Branch
- browse-content-raw-fileresponse
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 32784 Build 51364: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 51363: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D8836 (id=31848)
Rebasing onto ed38856c60...
Current branch diff-target is up to date.
Changes applied before test
commit ad8558c69d882a8a4453c7c6e04b4aeac384ec0d
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date: Mon Nov 14 13:41:07 2022 +0100
browse: Use django FileResponse in browse-content-raw view
Instead of manually setting some HTTP headers, prefer to use django
FileResponse class that set those.
It fixes the download of raw files with non ascii filenames.See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2129/ for more details.