Previous URL was starting with /api/1/vault/git_bare/ leading to a 404
while the correct one must start with /api/1/vault/git-bare/.
Details
Details
- Reviewers
vlorentz - Group Reviewers
Reviewers - Commits
- rDVAUb77c5ecef778: backend: Fix git_bare bundle download URL sent in email notification
Diff Detail
Diff Detail
- Repository
- rDVAU Software Heritage Vault
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Patch application report for D8818 (id=31794)
Rebasing onto d6de3a4d1e...
Current branch diff-target is up to date.
Changes applied before test
commit b77c5ecef778427829123a499bc3436511b40bfc Author: Antoine Lambert <anlambert@softwareheritage.org> Date: Mon Nov 7 13:50:09 2022 +0100 backend: Fix git_bare bundle download URL sent in email notification Previous URL was starting with /api/1/vault/git_bare/ leading to a 404 while the correct one must start with /api/1/vault/git-bare/.
See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/256/ for more details.
swh/vault/backend.py | ||
---|---|---|
454 | seems hacky. Shouldn't swh-web adapt its URL to the vault instead? |
swh/vault/backend.py | ||
---|---|---|
454 | I do not think so, we choose to use - to separate words in all API URLs so better sticking to it. |