Differential D8803

journal writer: only flush kafka once per batch
ClosedPublic
Actions

Authored by olasd on Nov 3 2022, 9:50 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDCIDXb7f04dd9d40d: journal writer: only flush kafka once per batch

Summary

This code was flushing kafka messages and waiting for the brokers on
every message, instead of just doing it once per batch.

Diff Detail

Repository

rDCIDX Metadata indexer

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 32681
Build 51198: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 51197: arc lint + arc unit

Event Timeline

olasd created this revision.Nov 3 2022, 9:50 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 3 2022, 9:50 AM

Build is green

Patch application report for D8803 (id=31727)

Rebasing onto 41e90e4ae6...

Current branch diff-target is up to date.

Changes applied before test

commit b7f04dd9d40dbe9463dbb1a2636d584efc82876c
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Thu Nov 3 09:49:03 2022 +0100

    journal writer: only flush kafka once per batch
    
    This code was flushing kafka messages and waiting for the brokers on
    every message, instead of just doing it once per batch.

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/524/ for more details.

Harbormaster completed remote builds in B32681: Diff 31727.Nov 3 2022, 9:55 AM

olasd requested review of this revision.Nov 3 2022, 9:55 AM