Also update crosswalk.csv from CodeMeta, so it includes changes from
https://github.com/codemeta/codemeta/pull/203
Details
- Reviewers
olasd - Group Reviewers
Reviewers - Maniphest Tasks
- T1327: Add Python metadata indexer
Diff Detail
- Repository
- rDCIDX Metadata indexer
- Branch
- python-pkginfo
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 3244 Build 4169: tox-on-jenkins Jenkins Build 4168: arc lint + arc unit
Event Timeline
Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/168/ for more details.
It's too bad the classifiers don't get mapped to anything useful!
Looks like we could import more metadata than what's currently there (e.g. license info), is it expected that it doesn't appear in the test data?
swh/indexer/metadata_dictionary.py | ||
---|---|---|
364–372 | I'm surprised flake8 is happy about those +es |
It's too bad the classifiers don't get mapped to anything useful!
Yes. I'll probably add it in the future, I just need a nice way to write it in CodeMeta's crosswalk table (which is designed to be human-readable (including non-programmers), but we use as machine input anyway)
Looks like we could import more metadata than what's currently there (e.g. license info), is it expected that it doesn't appear in the test data?
I copy-pasted the PKG-INFO from PyPI. We don't have license info because that field is missing from swh.core's setup.py.
I meant that the (UNKNOWN) info didn't get mapped in the metadata that we're importing in swh.
Or maybe that's just because the initial data is UNKNOWN? If that's the case it'd be nicer to use a more complete PKG-INFO file for our tests.
Yes it is. As I said, I copy-pasted from PyPI
If that's the case it'd be nicer to use a more complete PKG-INFO file for our tests.
Indeed, done. Good catch, there was a bug in the handling of licenses :)
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/172/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/172/console
Duh, I missed the if value != 'UNKNOWN' line.
If that's the case it'd be nicer to use a more complete PKG-INFO file for our tests.
Indeed, done. Good catch, there was a bug in the handling of licenses :)
Well, that stub is hardly a "more complete" PKG-INFO file, but better and more focused coverage is good nonetheless.
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/174/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/174/console