Page MenuHomeSoftware Heritage

tar.loader: Remove retro-compatible name
ClosedPublic

Authored by ardumont on Dec 20 2018, 5:46 PM.

Details

Summary

The deposit was the last one using that name.

It got removed in rDDEP4e60ea23849764d215bc9c9e9eb477578dfb772f

Test Plan

tox

Diff Detail

Repository
rDLDTAR Tarball Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Dec 20 2018, 5:46 PM
ardumont edited the summary of this revision. (Show Details)Dec 20 2018, 5:48 PM
olasd accepted this revision.Dec 20 2018, 6:11 PM
olasd added a subscriber: olasd.

This technically looks fine, but I'm surprised that we're keeping a LegacyLocalTarLoader if we're not going to deprecate it. We should figure out whether we can drop it completely at some point?

This revision is now accepted and ready to land.Dec 20 2018, 6:11 PM
In D871#18661, @olasd wrote:

This technically looks fine, but I'm surprised that we're keeping a LegacyLocalTarLoader if we're not going to deprecate it. We should figure out whether we can drop it completely at some point?

Yes, dropping it is the goal.
That legacy tar loader is a simple, decompress this and by the way, use this origin, revision, and snapshot that i gave you as scaffolding (don't forget to fill in the identifier when you're done completing the holes).
It was used for the first gnu tarball ingestion.

Then it got used (and still is) by the deposit loader (inheriting from it).

I'd like to refactor the deposit loader to stop inheriting from this one and use a collaborator approach instead.
This will help, most notably for the sparse deposit.

Then, we should be able to drop this.

This revision was automatically updated to reflect the committed changes.