Page MenuHomeSoftware Heritage

Fix _sanitize_github_url removing suffixes too greedily
ClosedPublic

Authored by vlorentz on Oct 13 2022, 2:57 PM.

Details

Summary

.rstrip() is not .removesuffix()

Diff Detail

Repository
rDCORE Foundations and core functionalities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D8674 (id=31330)

Rebasing onto 6a5ad76185...

Current branch diff-target is up to date.
Changes applied before test
commit 98fe7fe800c21c841b6e8d2f0717c097990160f0
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Oct 13 14:57:07 2022 +0200

    Fix _sanitize_github_url removing suffixes too greedily
    
    .rstrip() is not .removesuffix()

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/483/ for more details.

This revision is now accepted and ready to land.Oct 13 2022, 4:32 PM