Differential D8674

Fix _sanitize_github_url removing suffixes too greedily
ClosedPublic
Actions

Authored by vlorentz on Oct 13 2022, 2:57 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDCORE98fe7fe800c2: Fix _sanitize_github_url removing suffixes too greedily

Summary

.rstrip() is not .removesuffix()

Diff Detail

Repository

rDCORE Foundations and core functionalities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Oct 13 2022, 2:57 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 13 2022, 2:57 PM

Build is green

Patch application report for D8674 (id=31330)

Rebasing onto 6a5ad76185...

Current branch diff-target is up to date.

Changes applied before test

commit 98fe7fe800c21c841b6e8d2f0717c097990160f0
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Oct 13 14:57:07 2022 +0200

    Fix _sanitize_github_url removing suffixes too greedily
    
    .rstrip() is not .removesuffix()

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/483/ for more details.

Harbormaster completed remote builds in B32278: Diff 31330.Oct 13 2022, 2:59 PM

vlorentz requested review of this revision.Oct 13 2022, 2:59 PM

vlorentz added a child revision: D8673: packagist: Canonicalize github origins.Oct 13 2022, 4:28 PM

anlambert accepted this revision.Oct 13 2022, 4:32 PM

This revision is now accepted and ready to land.Oct 13 2022, 4:32 PM

Closed by commit rDCORE98fe7fe800c2: Fix _sanitize_github_url removing suffixes too greedily (authored by vlorentz). · Explain WhyOct 13 2022, 4:41 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDCORE98fe7fe800c2: Fix _sanitize_github_url removing suffixes too greedily.

Revision Contents
Changeset List

Path

Size

swh/

core/

github/

tests/

test_github_utils.py

6 lines

utils.py

7 lines

Diff 31343

View Options

swh/core/github/tests/test_github_utils.py