it's not used, and keeping it makes code unnecessarly complex.
Details
Details
- Reviewers
vlorentz - Group Reviewers
Reviewers - Commits
- rDPROVa0b2f0e9da09: Remove the without-path db flavor
Diff Detail
Diff Detail
- Repository
- rDPROV Provenance database
- Branch
- master
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 32268 Build 50542: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 50541: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D8668 (id=31306)
Rebasing onto b3fa1f5924...
Current branch diff-target is up to date.
Changes applied before test
commit 9f33b2df31c9449e52e00984bbc614a0152bdfd1
Author: David Douard <david.douard@sdfa3.org>
Date: Wed Oct 12 15:16:54 2022 +0200
Remove the without-path db flavor
it's not used, and keeping it makes code unnecessarly complex.See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/688/ for more details.
| swh/provenance/sql/30-schema.sql | ||
|---|---|---|
| 23–33 | why are they nullable now? and I don't see a corresponding schema change in the migration script | |
| swh/provenance/sql/30-schema.sql | ||
|---|---|---|
| 23–33 | because I included this chunk in this diff while it should be in the next diff... I need them to be nullable the same reason the revision's date was nullable; so that we can add sha1-only rows in the provenance db as a temporary step for being able to insert relation rows (content_in_revision, etc) This is needed (for the next diff) to be able to replay kafka messages as they come (eg without the need to have replayed the content involved in a content_in_revision before that later). Maybe it's worth a 'replica' flavor (where these not null are removed only in a replica provenance db, but I don't think it's really necessary...) | |
Comment Actions
Build is green
Patch application report for D8668 (id=31315)
Rebasing onto b3fa1f5924...
Current branch diff-target is up to date.
Changes applied before test
commit a0b2f0e9da09b8d2ddbaa80dfd57473185327dd7
Author: David Douard <david.douard@sdfa3.org>
Date: Wed Oct 12 15:16:54 2022 +0200
Remove the without-path db flavor
it's not used, and keeping it makes code unnecessarly complex.See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/692/ for more details.