This is an import from the replication package in
https://annex.softwareheritage.org/public/dataset/license-blobs/2021-03-23/
based on the closest commit I could find + a merge commit
(to reflect the actual history)
Details
Details
- Reviewers
- None
- Group Reviewers
Reviewers - Commits
- rDGRPHb5ea368cd4a2: Merge branch 'import-from-license-dataset'
rDGRPHe5574bccb4d9: FindEarliestRevision: Add earliest_ts and rev_occurrences columns
Diff Detail
Diff Detail
- Repository
- rDGRPH Compressed graph representation
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/261/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/261/console
Comment Actions
ugh that's nonesense, there are undefined vars because of 352d27f4b3f6b230757966ea73eb7c123d56337c
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/262/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/262/console
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/263/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/263/console
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/264/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/264/console
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/265/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/265/console
Comment Actions
not sure I understand what's going on here.
| java/src/main/java/org/softwareheritage/graph/utils/FindEarliestRevision.java | ||
|---|---|---|
| 1–2 | I guess it comes from the merge, but why adding individual copyright statements here? | |
| 1–6 | -2022 ? | |
| 63 | ah it took me a bit to figure out what TSV was... I see no advantage of using this instead of CSV (even if the sep id the tab) | |
| 99 | 'misssing' is MIN_VALUE and epoch is 0 right? Just in case, in provenance, I think we found there are also quite some "bogus" TS in an [EPOCH, EPOCH+epsilon] range | |
Comment Actions
Also I don't understand what "this is an import from replication package" means in this context...
Comment Actions
It means I checked out 0068f61008e6209d8739738659c86464417f020c, extracted replication/java/FindEarliestRevision.java from https://annex.softwareheritage.org/public/dataset/license-blobs/2021-03-23/replication-package.tar.gz , committed, then merged with current master
| java/src/main/java/org/softwareheritage/graph/utils/FindEarliestRevision.java | ||
|---|---|---|
| 1–2 | yes, it is | |
| 1–6 | hmm yes, I guess | |
| 99 | hmm yes, that makes sense. I'll send another diff. | |
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/266/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/266/console
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/267/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/267/console