Details
- Reviewers
anlambert - Group Reviewers
Reviewers - Maniphest Tasks
- T3781: Replace the Nixguix loader with a lister
- Commits
- rDLDBASE028b7c04b9ed: ContentLoader: Allow nar computation checks
Diff Detail
- Repository
- rDLDBASE Generic VCS/Package Loader
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 32139 Build 50322: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 50321: arc lint + arc unit
Event Timeline
Build is green
Patch application report for D8636 (id=31181)
Rebasing onto 8aa6dab72a...
Current branch diff-target is up to date.
Changes applied before test
commit 72406e67d571bf77c3b38278429010ade07f2ccb
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Thu Oct 6 12:22:45 2022 +0200
ContentLoader: Allow nar computation checks
"nar" computation checks can happen on files too.
This also deduplicate tests code on content and directory ones.
Related to T3781See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/965/ for more details.
Looks good to me, I added a couple of nitpick comments.
| swh/loader/core/tests/conftest.py | ||
|---|---|---|
| 43–64 | I would rather put this function in swh.loader.core.utils module as it could be useful elsewhere, also I think adding a tarball boolean parameter instead of checking extension would make it more generic. | |
| swh/loader/core/tests/test_loader.py | ||
| 610 | reason="requires nix-store executable from nix binaries" | |
| 787 | ditto | |
| swh/loader/core/tests/conftest.py | ||
|---|---|---|
| 43–64 | It was not generic because it's a test utils (using the nix_hashes function from the module you mention). But yes, if we move it as you said, fine, that's gonna how it will end up being implemented. Although, if we do move it, short of hard-coding some hashes (or mock), i don't really know how to test it. | |
| swh/loader/core/tests/conftest.py | ||
|---|---|---|
| 43–64 | Fine for me to let it this way then. | |
| swh/loader/core/tests/conftest.py | ||
|---|---|---|
| 43–64 | I went with hard-coding a hash as a non-reg test. That's how the test is doing it for tarball. | |
Build is green
Patch application report for D8636 (id=31215)
Rebasing onto 8aa6dab72a...
Current branch diff-target is up to date.
Changes applied before test
commit 8babe9656ab2bf7a4c025c4016d023e15ae48af2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Thu Oct 6 12:22:45 2022 +0200
ContentLoader: Allow nar computation checks
"nar" computation checks can happen on files too.
This also deduplicate tests code on content and directory ones.
Related to T3781See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/974/ for more details.
Build is green
Patch application report for D8636 (id=31215)
Rebasing onto 8aa6dab72a...
Current branch diff-target is up to date.
Changes applied before test
commit 8babe9656ab2bf7a4c025c4016d023e15ae48af2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Thu Oct 6 12:22:45 2022 +0200
ContentLoader: Allow nar computation checks
"nar" computation checks can happen on files too.
This also deduplicate tests code on content and directory ones.
Related to T3781See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/975/ for more details.
Build is green
Patch application report for D8636 (id=31215)
Rebasing onto 8aa6dab72a...
Current branch diff-target is up to date.
Changes applied before test
commit 8babe9656ab2bf7a4c025c4016d023e15ae48af2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Thu Oct 6 12:22:45 2022 +0200
ContentLoader: Allow nar computation checks
"nar" computation checks can happen on files too.
This also deduplicate tests code on content and directory ones.
Related to T3781See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/976/ for more details.
Build is green
Patch application report for D8636 (id=31218)
Rebasing onto 8aa6dab72a...
Current branch diff-target is up to date.
Changes applied before test
commit 028b7c04b9edd8fba65d40e0075897effc2222e6
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Thu Oct 6 12:22:45 2022 +0200
ContentLoader: Allow nar computation checks
"nar" computation checks can happen on files too.
This also deduplicate tests code on content and directory ones.
Related to T3781See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/977/ for more details.
Build is green
Patch application report for D8636 (id=31218)
Rebasing onto 8aa6dab72a...
Current branch diff-target is up to date.
Changes applied before test
commit 028b7c04b9edd8fba65d40e0075897effc2222e6
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Thu Oct 6 12:22:45 2022 +0200
ContentLoader: Allow nar computation checks
"nar" computation checks can happen on files too.
This also deduplicate tests code on content and directory ones.
Related to T3781See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/979/ for more details.
Build is green
Patch application report for D8636 (id=31218)
Rebasing onto 8aa6dab72a...
Current branch diff-target is up to date.
Changes applied before test
commit 028b7c04b9edd8fba65d40e0075897effc2222e6
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Thu Oct 6 12:22:45 2022 +0200
ContentLoader: Allow nar computation checks
"nar" computation checks can happen on files too.
This also deduplicate tests code on content and directory ones.
Related to T3781See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/980/ for more details.