Differential D8626

nixguix: Improve is_tarball detection pattern
ClosedPublic
Actions

Authored by ardumont on Oct 5 2022, 11:53 AM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T3781: Replace the Nixguix loader with a lister

Commits

rDLSf2377c283ac5: nixguix: Improve is_tarball detection pattern

Summary

This actually includes all query param values as paths to check. When paths have
extensions, it then pattern matches against tarballs if any. When no extension is
detected, it's doing as before, fallbacks to head query the url to have more information
on the file.

Prior to this commit, this only looked over a hard-coded list of values (for hard-coded
keys: file, f, name, url) detected through docker runs. This way of doing it should
decrease future misdetections (when new unknown "keys" show up in the wild).

Related to T3781

Diff Detail

Repository

rDLS Listers

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 32109
Build 50273: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 50272: arc lint + arc unit

Event Timeline

ardumont created this revision.Oct 5 2022, 11:53 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 5 2022, 11:53 AM

ardumont edited the summary of this revision. (Show Details)Oct 5 2022, 11:55 AM

ardumont edited the summary of this revision. (Show Details)

Build is green

Patch application report for D8626 (id=31138)

Rebasing onto 2ee103e2bc...

Current branch diff-target is up to date.

Changes applied before test

commit 202a571dee7c14fba37729104e707e85f2d25cef
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 5 11:52:43 2022 +0200

    nixguix: Refactor is_tarball to simplify
    
    Related to T3781

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/756/ for more details.

Harbormaster completed remote builds in B32106: Diff 31138.Oct 5 2022, 11:58 AM

ardumont requested review of this revision.Oct 5 2022, 11:58 AM

ardumont retitled this revision from nixguix: Refactor is_tarball to simplify to nixguix: Improve is_tarball detection pattern.Oct 5 2022, 12:01 PM

ardumont edited the summary of this revision. (Show Details)

Amend commit

really amend commit message ¯\_(ツ)_/¯

ardumont mentioned this in T3781: Replace the Nixguix loader with a lister.Oct 5 2022, 12:04 PM

Build is green

Patch application report for D8626 (id=31142)

Rebasing onto 2ee103e2bc...

Current branch diff-target is up to date.

Changes applied before test

commit 3da112ce060a2de9178cf62b79eba4558c928f0e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 5 11:52:43 2022 +0200

    nixguix: Improve is_tarball detection pattern
    
    This actually includes all query param values as paths to check. It then checks for file
    pattern matching against "tarball" patterns. When no extension is detected, it's doing
    as before, fallbacks to head query the url to have more information on the file.
    
    Prior to this commit, this only looked over a hard-coded list of keys (file, f, name,
    url) detected through docker runs. This way of doing it should decrease future
    misdetections.
    
    Related to T3781

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/757/ for more details.

Harbormaster completed remote builds in B32108: Diff 31142.Oct 5 2022, 12:07 PM

Build is green

Patch application report for D8626 (id=31143)

Rebasing onto 2ee103e2bc...

Current branch diff-target is up to date.

Changes applied before test

commit f2377c283ac542a5b492a9d75ccce6d86b07c54a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 5 11:52:43 2022 +0200

    nixguix: Improve is_tarball detection pattern
    
    This actually includes all query param values as paths to check. When paths have
    extensions, it then pattern matches against tarballs if any. When no extension is
    detected, it's doing as before, fallbacks to head query the url to have more information
    on the file.
    
    Prior to this commit, this only looked over a hard-coded list of values (for hard-coded
    keys: file, f, name, url) detected through docker runs. This way of doing it should
    decrease future misdetections (when new unknown "keys" show up in the wild).
    
    Related to T3781

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/758/ for more details.

Harbormaster completed remote builds in B32109: Diff 31143.Oct 5 2022, 12:09 PM

anlambert accepted this revision.Oct 5 2022, 12:10 PM

This revision is now accepted and ready to land.Oct 5 2022, 12:10 PM

Closed by commit rDLSf2377c283ac5: nixguix: Improve is_tarball detection pattern (authored by ardumont). · Explain WhyOct 5 2022, 12:12 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLSf2377c283ac5: nixguix: Improve is_tarball detection pattern.