Page MenuHomeSoftware Heritage

SimpleTraversal.visitNode: Remove redundant boolean
ClosedPublic

Authored by vlorentz on Sep 30 2022, 11:30 AM.

Details

Diff Detail

Repository
rDGRPH Compressed graph representation
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D8583 (id=30987)

Could not rebase; Attempt merge onto 8549673d02...

Merge made by the 'recursive' strategy.
 docs/api.rst                                       |  4 +++
 .../org/softwareheritage/graph/rpc/Traversal.java  | 18 +++++-----
 swh/graph/http_client.py                           | 19 ++++++++--
 swh/graph/http_naive_client.py                     | 17 +++++++--
 swh/graph/tests/test_http_client.py                | 42 ++++++++++++++++++++++
 5 files changed, 84 insertions(+), 16 deletions(-)
Changes applied before test
commit f51e4bec1dcfc50e2b77f37701b992255b398e61
Merge: 8549673 9a3c45d
Author: Jenkins user <jenkins@localhost>
Date:   Fri Sep 30 09:31:34 2022 +0000

    Merge branch 'diff-target' into HEAD

commit 9a3c45d1c9e4e4464631ffa6bf654b74f026e74f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Sep 30 11:29:40 2022 +0200

    SimpleTraversal.visitNode: Remove redundant boolean

commit e2dfaf726bdcf3cdad13b8f9c67b1d494dbef083
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 29 15:41:27 2022 +0200

    Apply 'max_matching_nodes' restriction after 'return_types' filter
    
    Otherwise, less results may be returned, if the non-matching nodes are
    before the matching ones.

commit b4504ecb3cb5de7db7d36a8b3a6d34a899f49636
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 29 15:39:27 2022 +0200

    http_client: Add max_matching_nodes parameter to visit_nodes()

See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/257/ for more details.

This revision is now accepted and ready to land.Sep 30 2022, 2:18 PM
This revision was landed with ongoing or failed builds.Sep 30 2022, 3:18 PM
This revision was automatically updated to reflect the committed changes.