http_client: Add max_matching_nodes parameter to visit_nodes()
ClosedPublic
Actions

Authored by vlorentz on Sep 29 2022, 3:43 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T4586: max_matching_nodes is applied before filtering for node type

Commits

rDGRPHbc4e710a50e5: http_client: Add max_matching_nodes parameter to visit_nodes()

Summary

Needed to write tests for the fix to T4586.

Diff Detail

Repository

rDGRPH Compressed graph representation

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Sep 29 2022, 3:43 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 29 2022, 3:43 PM

vlorentz added a child revision: D8580: Apply 'max_matching_nodes' restriction after 'return_types' filter.Sep 29 2022, 3:43 PM

vlorentz added a task: T4586: max_matching_nodes is applied before filtering for node type.Sep 29 2022, 3:43 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/250/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/250/console

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 29 2022, 3:44 PM

Harbormaster failed remote builds in B31924: Diff 30952!

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/252/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/252/console

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/254/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/254/console

Build is green

Patch application report for D8579 (id=30952)

Rebasing onto 8549673d02...

First, rewinding head to replay your work on top of it...
Applying: http_client: Add max_matching_nodes parameter to visit_nodes()

Changes applied before test

commit 92f4da382d83df4c6bf77401340ddefd54c63b61
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 29 15:39:27 2022 +0200

    http_client: Add max_matching_nodes parameter to visit_nodes()

See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/256/ for more details.

Harbormaster completed remote builds in B31924: Diff 30952.Sep 29 2022, 5:39 PM

vlorentz requested review of this revision.Sep 29 2022, 5:39 PM

anlambert added a subscriber: anlambert.Sep 30 2022, 2:22 PM

anlambert added inline comments.

swh/graph/http_naive_client.py
200	Should it not be `yield from res` instead ?

vlorentz added inline comments.Sep 30 2022, 2:33 PM

swh/graph/http_naive_client.py
200	er I guess, but it's functionally equivalent to `return res` from a function instead of `yield from res` from a generator when `res` is an iterator; that's why generators have the same type signature as a function returning an iterator