Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Maniphest Tasks
- T4401: Index metadata from the deposit
- Commits
- rDCIDXfc6fea5dd87f: codemeta: Fix crash when translating PropertyValue objects from codemeta-in…
Diff Detail
Diff Detail
- Repository
- rDCIDX Metadata indexer
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Patch application report for D8568 (id=30917)
Could not rebase; Attempt merge onto cdbf090b14...
Updating cdbf090..fc6fea5 Fast-forward swh/indexer/metadata_dictionary/codemeta.py | 9 +++++++- swh/indexer/metadata_dictionary/github.py | 13 ++++++++--- .../tests/metadata_dictionary/test_codemeta.py | 26 ++++++++++++++++++++++ .../tests/metadata_dictionary/test_github.py | 20 ++++++++++++++++- 4 files changed, 63 insertions(+), 5 deletions(-)
Changes applied before test
commit fc6fea5dd87f7a5b73f73e41f94acc9f60d9e96a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Wed Sep 28 18:06:02 2022 +0200
codemeta: Fix crash when translating PropertyValue objects from codemeta-in-SWORD
commit 6e4c67bede71b43f7b8fe10357065b71616ebc2a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Wed Sep 28 13:40:34 2022 +0200
github: Ignore archive_url and issues_url; use custom codemeta:issueTracker
The codemeta crosswalk maps archive_url and issues_url to codemeta
properties, but they are not actually useable because they are
link templates to API endpoints.See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/511/ for more details.
Comment Actions
lgtm
one suggestion inline.
| swh/indexer/metadata_dictionary/codemeta.py | ||
|---|---|---|
| 90 | you're nearly covered! So a nudge to make the extra effort for that case (please ;) | |