Page MenuHomeSoftware Heritage
Differential D850

Route tasks using their task name rather than a task_queue attribute
ClosedPublic
Actions

Authored by olasd on Dec 18 2018, 5:20 PM.

Details

Reviewers
vlorentz
Commits
rDSCH4cacd657c2f2: Route tasks using their task name rather than a task_queue attribute
Summary

Supersedes D839

Test Plan

tox (and make test on swh-indexer)

Diff Detail

Repository
rDSCH Scheduling utilities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Dec 18 2018, 5:20 PM
Harbormaster failed remote builds in B3147: Diff 2717!Dec 18 2018, 5:22 PM
swh-public-ci added a subscriber: swh-public-ci.Dec 18 2018, 5:22 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/47/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/47/console

olasd added a child revision: D852: Automatically subscribe workers to the per-task queues.Dec 18 2018, 5:28 PM
vlorentz added a comment.Dec 18 2018, 5:29 PM

How does this preserve compatibility with the current worker configurations? They would only listen on the old queue names

olasd added a comment.Dec 18 2018, 5:29 PM
In D850#18235, @vlorentz wrote:

How does this preserve compatibility with the current worker configurations? They would only listen on the old queue names

That would be D852.

vlorentz accepted this revision.Dec 18 2018, 5:30 PM
This revision is now accepted and ready to land.Dec 18 2018, 5:30 PM
Closed by commit rDSCH4cacd657c2f2: Route tasks using their task name rather than a task_queue attribute (authored by olasd). · Explain WhyDec 18 2018, 5:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
scheduler/
celery_backend/
8 lines
29 lines
1 line
tests/
5 lines

Diff 2724

View Options

swh/scheduler/celery_backend/config.py

Loading...
View Options

swh/scheduler/celery_backend/runner.py

Loading...
View Options

swh/scheduler/task.py

Loading...
View Options

swh/scheduler/tests/scheduler_testing.py

Loading...
About · Developer information · Legal