Fix swh-web 0.1.x execution in docker environment
ClosedPublic
Actions

Authored by anlambert on Sep 14 2022, 2:05 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDWAPPS58fae8e0ea08: webapp/urls: Restore exception handling when fetching history counters
rDWAPPS13e95bc86cc0: settings/production: Remove login/logout URL settings

Summary

Some adaptations were missed during recent swh-web refactoring
to ensure the webapp can still be executed in docker enviroment,
see commit log below:

settings/production: Remove login/logout URL settings

It should have been removed in 104f3b79bf3a as these settings are now
handled in swh.web.settings.common.

This fixes webapp execution in docker environment.

webapp/urls: Restore exception handling when fetching history counters

This fixes an issue when executing the webapp in docker environment as
such file is not available here.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Sep 14 2022, 2:05 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 14 2022, 2:05 PM

Build is green

Patch application report for D8474 (id=30523)

Rebasing onto 5b0ab27a8d...

Current branch diff-target is up to date.

Changes applied before test

commit 53903cdb10f27506d908394f737c9a65a6b31c77
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Sep 14 14:00:31 2022 +0200

    webapp/urls: Restore exception handling when fetching history counters
    
    This fixes an issue when executing the webapp in docker environment as
    such file is not available here.

commit 13e95bc86cc0d024d57a97d48ed87c683e74e1a2
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Sep 14 13:58:30 2022 +0200

    settings/production: Remove login/logout URL settings
    
    It should have been removed in 104f3b79bf3a as these settings are now
    handled in swh.web.settings.common.
    
    This fixes webapp execution in docker environment.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2065/ for more details.

Harbormaster completed remote builds in B31525: Diff 30523.Sep 14 2022, 2:14 PM

anlambert requested review of this revision.Sep 14 2022, 2:14 PM

vlorentz requested changes to this revision.Sep 15 2022, 10:19 AM

vlorentz added a subscriber: vlorentz.

vlorentz added inline comments.

swh/web/webapp/urls.py
37–41 ↗	(On Diff #30523)	You should add a `log.exception` too, otherwise it would silently ignore errors

This revision now requires changes to proceed.Sep 15 2022, 10:19 AM

anlambert edited the summary of this revision. (Show Details)Sep 15 2022, 10:42 AM

Add logger.exception call

Build is green

Patch application report for D8474 (id=30544)

Rebasing onto 5b0ab27a8d...

Current branch diff-target is up to date.

Changes applied before test

commit 58fae8e0ea081f25e1b671a6f61285131e404ddc
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Sep 14 14:00:31 2022 +0200

    webapp/urls: Restore exception handling when fetching history counters
    
    This fixes an issue when executing the webapp in docker environment as
    such file is not available here.

commit 13e95bc86cc0d024d57a97d48ed87c683e74e1a2
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Sep 14 13:58:30 2022 +0200

    settings/production: Remove login/logout URL settings
    
    It should have been removed in 104f3b79bf3a as these settings are now
    handled in swh.web.settings.common.
    
    This fixes webapp execution in docker environment.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2067/ for more details.

Harbormaster completed remote builds in B31545: Diff 30544.Sep 15 2022, 10:57 AM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 15 2022, 11:01 AM

Closed by commit rDWAPPS13e95bc86cc0: settings/production: Remove login/logout URL settings (authored by anlambert). · Explain Why

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS13e95bc86cc0: settings/production: Remove login/logout URL settings.

anlambert added a commit: rDWAPPS58fae8e0ea08: webapp/urls: Restore exception handling when fetching history counters.