Page MenuHomeSoftware Heritage

Switch celery settings to lowercase names
ClosedPublic

Authored by olasd on Dec 18 2018, 5:18 PM.

Details

Summary

Depends on D846 (sort of)

Test Plan

tox

Diff Detail

Repository
rDSCH Scheduling utilities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Dec 18 2018, 5:18 PM
ardumont accepted this revision.Dec 18 2018, 5:22 PM
ardumont added a subscriber: ardumont.

Long time overdue ;)

I remember reading this a while back [1]

[1] http://docs.celeryproject.org/en/v4.0.1/whatsnew-4.0.html#lowercase-setting-names

This revision is now accepted and ready to land.Dec 18 2018, 5:22 PM
olasd added a comment.Dec 18 2018, 5:24 PM

Long time overdue ;)

I remember reading this a while back [1]

[1] http://docs.celeryproject.org/en/v4.0.1/whatsnew-4.0.html#lowercase-setting-names

Now that we're 4.x all the way there's no point keeping the backwards compatibility around :). That will also allow us to use the config that the celery test fixtures are shipping (although these settings turn out to not be that useful).

This revision was automatically updated to reflect the committed changes.