Add date-based index to origin_visit
ClosedPublic
Actions

Authored by olasd on Sep 13 2022, 4:07 PM.

Details

Reviewers

Group Reviewers

Commits

rDSTO1281ee7b7eeb: Add date-based index to origin_visit
rDSTO0786ab174902: SQL upgrade scripts don't need to bump dbversion anymore

Summary

This will help queries retrieving origin_visits by date by avoiding
having to scan all visits for the origin and then sorting them.

Test Plan

We did it in prod™

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Sep 13 2022, 4:07 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 13 2022, 4:07 PM

Only create index if not exists

Build is green

Patch application report for D8466 (id=30501)

Rebasing onto aa735cba51...

Current branch diff-target is up to date.

Changes applied before test

commit 1281ee7b7eeb4e05470edad1f7cd7b7eb2c7108c
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Sep 13 15:52:34 2022 +0200

    Add date-based index to origin_visit
    
    This will help queries retrieving origin_visits by date by avoiding
    having to scan all visits for the origin.

commit 0786ab17490233130ad2c0310ba14e0b7d56d8e9
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Sep 13 15:51:57 2022 +0200

    SQL upgrade scripts don't need to bump dbversion anymore

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1662/ for more details.

Harbormaster completed remote builds in B31508: Diff 30501.Sep 13 2022, 4:26 PM

olasd requested review of this revision.Sep 13 2022, 4:26 PM

Build was aborted

Patch application report for D8466 (id=30500)

Rebasing onto aa735cba51...

Current branch diff-target is up to date.

Changes applied before test

commit 7deca5730b4ac35866515b3aa6ab0e0761406ecb
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Sep 13 15:52:34 2022 +0200

    Add date-based index to origin_visit
    
    This will help queries retrieving origin_visits by date by avoiding
    having to scan all visits for the origin.

commit 0786ab17490233130ad2c0310ba14e0b7d56d8e9
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Sep 13 15:51:57 2022 +0200

    SQL upgrade scripts don't need to bump dbversion anymore

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1661/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1661/console

Harbormaster failed remote builds in B31507: Diff 30500!Sep 13 2022, 4:35 PM

ardumont accepted this revision.Sep 14 2022, 12:30 PM

This revision is now accepted and ready to land.Sep 14 2022, 12:30 PM

Rebase

Build is green

Patch application report for D8466 (id=30828)

Rebasing onto aa735cba51...

Current branch diff-target is up to date.

Changes applied before test

commit 1281ee7b7eeb4e05470edad1f7cd7b7eb2c7108c
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Sep 13 15:52:34 2022 +0200

    Add date-based index to origin_visit
    
    This will help queries retrieving origin_visits by date by avoiding
    having to scan all visits for the origin.

commit 0786ab17490233130ad2c0310ba14e0b7d56d8e9
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Sep 13 15:51:57 2022 +0200

    SQL upgrade scripts don't need to bump dbversion anymore

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1664/ for more details.

Harbormaster completed remote builds in B31804: Diff 30828.Sep 27 2022, 3:01 PM

Closed by commit rDSTO0786ab174902: SQL upgrade scripts don't need to bump dbversion anymore (authored by olasd). · Explain WhySep 27 2022, 3:03 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDSTO0786ab174902: SQL upgrade scripts don't need to bump dbversion anymore.

olasd added a commit: rDSTO1281ee7b7eeb: Add date-based index to origin_visit.