Remove the option to use a WSGI server
ClosedPublic
Actions

Authored by jayeshv on Sep 1 2022, 10:51 AM.

Details

Reviewers

ardumont
vlorentz

Group Reviewers

Reviewers

Commits

rDGQL660acc6aa448: Remove the option to use a WSGI server

Summary

Use only ASGI to serve the API.
Change makefile target to use UvicornWorker with gunicorn.
This will allow the server to use asynchronous features.
doc:
https://www.uvicorn.org/#running-with-gunicorn

Diff Detail

Repository

rDGQL GraphQL API

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jayeshv created this revision.Sep 1 2022, 10:51 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 1 2022, 10:51 AM

jayeshv added a reviewer: ardumont.Sep 1 2022, 10:52 AM

Build is green

Patch application report for D8374 (id=30216)

Rebasing onto ce8008dfb3...

Current branch diff-target is up to date.

Changes applied before test

commit 660acc6aa44897e45cd53da7ff1d95b77761b2f6
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu Sep 1 10:38:17 2022 +0200

    Remove the option to use a WSGI server
    
    Use only ASGI to serve the API.
    Change makefile target to use UvicornWorker with gunicorn.
    This will allow the server to use asynchronous features.

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/146/ for more details.

Harbormaster completed remote builds in B31254: Diff 30216.Sep 1 2022, 10:53 AM

jayeshv requested review of this revision.Sep 1 2022, 10:53 AM

vlorentz accepted this revision.Sep 1 2022, 10:58 AM

This revision is now accepted and ready to land.Sep 1 2022, 10:58 AM

Closed by commit rDGQL660acc6aa448: Remove the option to use a WSGI server (authored by jayeshv). · Explain WhySep 1 2022, 11:01 AM

This revision was automatically updated to reflect the committed changes.

jayeshv added a commit: rDGQL660acc6aa448: Remove the option to use a WSGI server.

jayeshv mentioned this in T4532: GraphQL: staging - Deploy version v0.0.4.Sep 13 2022, 11:33 AM

ardumont mentioned this in R259:1daf7a649686: swh-graphql: Adapt entrypoint according to latest change.Sep 13 2022, 2:42 PM