Differential D8367

cypress: Fix some flaky tests
ClosedPublic
Actions

Authored by anlambert on Aug 31 2022, 4:32 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T3423: Execute cypress tests in parallel on Jenkins

Commits

rDWAPPSde37826d1446: cypress/origin-save: Add missing wait instructions in a test
rDWAPPS506470cce04b: cypress/support: Add missing wait instruction in global before hook

Summary

When running cypress tests in parallel, some tests ended up as flaky
when multiple swh-web build jobs are executed concurrently (due to
test execution being slower).

Fix those by adding missing wait instructions in tests implementation.

Related to T3423

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Aug 31 2022, 4:32 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 31 2022, 4:32 PM

Build is green

Patch application report for D8367 (id=30191)

Rebasing onto 13751718e9...

Current branch diff-target is up to date.

Changes applied before test

commit de37826d144659c97c96d2071fccf75132f86678
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Aug 30 11:00:39 2022 +0200

    cypress/origin-save: Add missing wait instructions in a test
    
    Related to T3423

commit 506470cce04b9c7222d7bf676b5386359d951060
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Aug 29 20:03:18 2022 +0200

    cypress/support: Add missing wait instruction in global before hook
    
    Related to T3423

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2025/ for more details.

Harbormaster completed remote builds in B31235: Diff 30191.Aug 31 2022, 4:51 PM

anlambert requested review of this revision.Aug 31 2022, 4:51 PM

vlorentz accepted this revision.Aug 31 2022, 4:53 PM

This revision is now accepted and ready to land.Aug 31 2022, 4:53 PM

Closed by commit rDWAPPS506470cce04b: cypress/support: Add missing wait instruction in global before hook (authored by anlambert). · Explain WhyAug 31 2022, 4:56 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS506470cce04b: cypress/support: Add missing wait instruction in global before hook.

anlambert added a commit: rDWAPPSde37826d1446: cypress/origin-save: Add missing wait instructions in a test.