Differential D8317

misc/coverage: Move feature into its own django application
ClosedPublic
Actions

Authored by anlambert on Aug 25 2022, 5:03 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T4398: Create one django application for each webapp feature

Commits

rDWAPPSa7ab8afb1951: misc/coverage: Move feature into its own django application

Summary

Related to T4398

Diff Detail

Repository

rDWAPPS Web applications

Branch

django-apps-refactoring-coverage

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 31090
Build 48641: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 48640: arc lint + arc unit

Event Timeline

anlambert created this revision.Aug 25 2022, 5:03 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 25 2022, 5:03 PM

Build is green

Patch application report for D8317 (id=30041)

Rebasing onto 1f17548cd0...

Current branch diff-target is up to date.

Changes applied before test

commit 6c20986cb6101c812a3c3f5017eeb23ab7ec3370
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Aug 25 16:59:57 2022 +0200

    misc/coverage: Move feature into its own django application
    
    Related to T4398

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2013/ for more details.

Harbormaster completed remote builds in B31090: Diff 30041.Aug 25 2022, 5:19 PM

anlambert requested review of this revision.Aug 25 2022, 5:19 PM

lgtm,

one typo fix suggestion inline.

swh/web/tests/archive_coverage/test_app.py
18

This revision is now accepted and ready to land.Aug 25 2022, 5:36 PM

anlambert added inline comments.Aug 25 2022, 5:37 PM

swh/web/tests/archive_coverage/test_app.py
18	Whoops, thanks for spotting.

Fix docstring

Build is green

Patch application report for D8317 (id=30044)

Rebasing onto 1f17548cd0...

Current branch diff-target is up to date.

Changes applied before test

commit a7ab8afb1951fc6c7d6cce8fe20989b1473fc413
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Aug 25 16:59:57 2022 +0200

    misc/coverage: Move feature into its own django application
    
    Related to T4398

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2014/ for more details.

Harbormaster completed remote builds in B31092: Diff 30044.Aug 25 2022, 5:58 PM

Closed by commit rDWAPPSa7ab8afb1951: misc/coverage: Move feature into its own django application (authored by anlambert). · Explain WhyAug 25 2022, 7:40 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPSa7ab8afb1951: misc/coverage: Move feature into its own django application.