Page MenuHomeSoftware Heritage
Differential D8304

Add alias type to the branch target
ClosedPublic
Actions

Authored by jayeshv on Aug 24 2022, 1:15 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
T4309: GraphQL: Add missing target types in snapshot branch
Commits
rDGQL527bf88bdb24: Add alias type to the branch target
Summary

Return a branch object when the branch target is an alias type

Related to T4309

Diff Detail

Repository
rDGQL GraphQL API
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jayeshv created this revision.Aug 24 2022, 1:15 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptAug 24 2022, 1:15 PM
swh-public-ci added a comment.Aug 24 2022, 1:17 PM

Build is green

Patch application report for D8304 (id=29979)

Rebasing onto 6fb1913ff9...

Current branch diff-target is up to date.
Changes applied before test
commit 4aefb1aab9c7a4d08692a2944dcf8be5ad9102a6
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Aug 23 12:00:59 2022 +0200

    Add alias type to the branch target
    
    Return a branch object when the branch target is an alias type
    
    Related to T4309

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/120/ for more details.

Harbormaster completed remote builds in B31028: Diff 29979.Aug 24 2022, 1:17 PM
jayeshv requested review of this revision.Aug 24 2022, 1:17 PM
vlorentz retitled this revision from WIP Add alias type to the branch target to [WIP] Add alias type to the branch target.Aug 24 2022, 1:28 PM
jayeshv updated this revision to Diff 29982.Aug 24 2022, 1:51 PM

doc improvements

swh-public-ci added a comment.Aug 24 2022, 1:53 PM

Build is green

Patch application report for D8304 (id=29982)

Rebasing onto 6fb1913ff9...

Current branch diff-target is up to date.
Changes applied before test
commit 083b3c2fae4852499c25c27fdac3db849e861ead
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Aug 23 12:00:59 2022 +0200

    Add alias type to the branch target
    
    Return a branch object when the branch target is an alias type
    
    Related to T4309

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/121/ for more details.

Harbormaster completed remote builds in B31031: Diff 29982.Aug 24 2022, 1:53 PM
jayeshv retitled this revision from [WIP] Add alias type to the branch target to Add alias type to the branch target.Aug 24 2022, 1:53 PM
jayeshv edited the summary of this revision. (Show Details)
ardumont accepted this revision.Aug 25 2022, 10:05 AM
ardumont added a subscriber: ardumont.

lgtm

couple of non-blocking suggestions inline

swh/graphql/resolvers/snapshot_branch.py
36

I believe we usually raise a NotImplementedError instead.

46

why do you comment it?

49

if you uncomment line 48, this comment is no longer needed ;)

53
swh/graphql/tests/functional/test_branch_connection.py
62–63
This revision is now accepted and ready to land.Aug 25 2022, 10:05 AM
jayeshv updated this revision to Diff 30014.Aug 25 2022, 11:32 AM

Address review comments

jayeshv marked 4 inline comments as done.Aug 25 2022, 11:34 AM
jayeshv added inline comments.
swh/graphql/resolvers/snapshot_branch.py
46

This is because of a circular import. I have to restructure this a bit to avoid that. Will do that as part of another re-factoring.

swh/graphql/tests/functional/test_branch_connection.py
62–63

Renamed the function and moved the functions aroud.

swh-public-ci added a comment.Aug 25 2022, 11:35 AM

Build is green

Patch application report for D8304 (id=30014)

Rebasing onto 5cf1ac26d9...

Current branch diff-target is up to date.
Changes applied before test
commit 67b52a28d194ff39d33a4e6a687a9c439a0e29b3
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Aug 23 12:00:59 2022 +0200

    Add alias type to the branch target
    
    Return a branch object when the branch target is an alias type
    
    Related to T4309

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/126/ for more details.

Harbormaster completed remote builds in B31063: Diff 30014.Aug 25 2022, 11:35 AM
jayeshv updated this revision to Diff 30015.Aug 25 2022, 11:41 AM
jayeshv marked an inline comment as done.

docstring correction

swh-public-ci added a comment.Aug 25 2022, 11:43 AM

Build is green

Patch application report for D8304 (id=30015)

Rebasing onto 5cf1ac26d9...

Current branch diff-target is up to date.
Changes applied before test
commit 527bf88bdb24b60a866a3ab1a3a71fcf2342e650
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Aug 23 12:00:59 2022 +0200

    Add alias type to the branch target
    
    Return a branch object when the branch target is an alias type
    
    Related to T4309

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/127/ for more details.

Harbormaster completed remote builds in B31064: Diff 30015.Aug 25 2022, 11:43 AM
Closed by commit rDGQL527bf88bdb24: Add alias type to the branch target (authored by jayeshv). · Explain WhyAug 25 2022, 12:58 PM
This revision was automatically updated to reflect the committed changes.
jayeshv added a commit: rDGQL527bf88bdb24: Add alias type to the branch target.

Revision Contents
Changeset List

PathSize
swh/
graphql/
backends/
2 lines
resolvers/
4 lines
4 lines
4 lines
3 lines
5 lines
4 lines
4 lines
79 lines
tests/
functional/
25 lines

Diff 30024

View Options

swh/graphql/backends/archive.py

Loading...
View Options

swh/graphql/resolvers/content.py

Loading...
View Options

swh/graphql/resolvers/directory.py

Loading...
View Options

swh/graphql/resolvers/release.py

Loading...
View Options

swh/graphql/resolvers/resolver_factory.py

Loading...
View Options

swh/graphql/resolvers/resolvers.py

Loading...
View Options

swh/graphql/resolvers/revision.py

Loading...
View Options

swh/graphql/resolvers/snapshot.py

Loading...
View Options

swh/graphql/resolvers/snapshot_branch.py

Loading...
View Options

swh/graphql/tests/functional/test_branch_connection.py

Loading...
About · Developer information · Legal