auth/utils: Fix circular import triggered by sphinx autodoc
ClosedPublic
Actions

Authored by anlambert on Aug 23 2022, 12:01 PM.

Details

Reviewers

Group Reviewers

Commits

rDWAPPScb2f35021f60: auth/utils: Fix circular import triggered by sphinx autodoc
rDWAPPS57c6590017b7: Remove no longer needed swh/web/common folder

Summary

Fix "cannot import name 'ADD_FORGE_MODERATOR_PERMISSION' from
'swh.web.auth.utils'" when autodoc processes the admin_views
module from swh.web.add_forge_now.

https://jenkins.softwareheritage.org/job/DDOC/job/dev/2156/artifact/swh-docs/docs/errors.log

Also remove no longer needed swh/web/common folder.

Diff Detail

Repository

rDWAPPS Web applications

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 30990
Build 48473: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 48472: arc lint + arc unit

Event Timeline

anlambert created this revision.Aug 23 2022, 12:01 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 23 2022, 12:01 PM

Build is green

Patch application report for D8290 (id=29938)

Rebasing onto 1975f2b38b...

Current branch diff-target is up to date.

Changes applied before test

commit cb2f35021f60dc816c7fa326100f6c20b1ab5192
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Aug 23 11:59:00 2022 +0200

    auth/utils: Fix circular import triggered by sphinx autodoc
    
    Fix "cannot import name 'ADD_FORGE_MODERATOR_PERMISSION' from
    'swh.web.auth.utils'" when autodoc processes the admin_views
    module from swh.web.add_forge_now.

commit 57c6590017b7d2217782a58e18e312dd11dc8f13
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Aug 22 13:17:29 2022 +0200

    Remove no longer needed swh/web/common folder

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1994/ for more details.

Harbormaster completed remote builds in B30990: Diff 29938.Aug 23 2022, 12:16 PM

anlambert requested review of this revision.Aug 23 2022, 12:16 PM

vlorentz accepted this revision.Aug 23 2022, 1:04 PM

This revision is now accepted and ready to land.Aug 23 2022, 1:04 PM

Closed by commit rDWAPPS57c6590017b7: Remove no longer needed swh/web/common folder (authored by anlambert). · Explain WhyAug 23 2022, 1:13 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS57c6590017b7: Remove no longer needed swh/web/common folder.

anlambert added a commit: rDWAPPScb2f35021f60: auth/utils: Fix circular import triggered by sphinx autodoc.