gitea: Inherit from Gogs lister
ClosedPublic
Actions

Authored by vlorentz on Aug 23 2022, 11:51 AM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDLS17a219ece084: gitea: Inherit from Gogs lister

Summary

This removes code and adds support for incremental pagination.

While both are essentially the same lister now, it still makes sense to
keep the Gitea lister separate, in order to:

display them in different categories on https://archive.softwareheritage.org/
support possible divergence of APIs in the future

Diff Detail

Repository

rDLS Listers

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Aug 23 2022, 11:51 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 23 2022, 11:51 AM

Build is green

Patch application report for D8289 (id=29937)

Rebasing onto dde7865ac4...

Current branch diff-target is up to date.

Changes applied before test

commit 0ec13061f8aefdd271594a4a40eff7ec46e2d699
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Aug 23 11:49:40 2022 +0200

    gitea: Inherit from Gogs lister
    
    This removes code and adds support for incremental pagination.
    
    While both are essentially the same lister now, it still makes sense to
    keep the Gitea lister separate, in order to:
    
    1. display them in different categories on https://archive.softwareheritage.org/
    2. support possible divergence of APIs in the future

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/602/ for more details.

Harbormaster completed remote builds in B30989: Diff 29937.Aug 23 2022, 11:55 AM

vlorentz requested review of this revision.Aug 23 2022, 11:55 AM

properly handle None case

Build is green

Patch application report for D8289 (id=29944)

Rebasing onto dde7865ac4...

Current branch diff-target is up to date.

Changes applied before test

commit 17a219ece0846b4cb4a27ac0ac6ab1b9d681b0ad
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Aug 23 11:49:40 2022 +0200

    gitea: Inherit from Gogs lister
    
    This removes code and adds support for incremental pagination.
    
    While both are essentially the same lister now, it still makes sense to
    keep the Gitea lister separate, in order to:
    
    1. display them in different categories on https://archive.softwareheritage.org/
    2. support possible divergence of APIs in the future

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/603/ for more details.

Harbormaster completed remote builds in B30996: Diff 29944.Aug 23 2022, 1:43 PM

Looks good to me.

As other listers (like gitlab) and probably future ones also return next page links in HTTP response headers,
I think we should add a new lister class (HTTPLinkHeaderLister for instance) wrapping common processing
to get the next page link and inherits from it in relevant listers.
But that's out of scope for that diff.

This revision is now accepted and ready to land.Aug 23 2022, 1:59 PM

Closed by commit rDLS17a219ece084: gitea: Inherit from Gogs lister (authored by vlorentz). · Explain WhyAug 23 2022, 4:53 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDLS17a219ece084: gitea: Inherit from Gogs lister.