Differential D8252

Deduplicate statsd calls
ClosedPublic
Actions

Authored by vlorentz on Aug 18 2022, 3:07 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDSCRUB0cc86b0e45f0: Deduplicate statsd calls

Summary

This will allow adding more tags easily in future commits

Diff Detail

Repository

rDSCRUB Datastore Scrubber

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 30861
Build 48256: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 48255: arc lint + arc unit

Event Timeline

vlorentz created this revision.Aug 18 2022, 3:07 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 18 2022, 3:07 PM

Build is green

Patch application report for D8252 (id=29809)

Rebasing onto c6f711ecbf...

Current branch diff-target is up to date.

Changes applied before test

commit 0cc86b0e45f015429406112b16e8b2e5196512ba
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 18 15:07:19 2022 +0200

    Deduplicate statsd calls
    
    This will allow adding more tags easily in future commits

See https://jenkins.softwareheritage.org/job/DSCRUB/job/tests-on-diff/53/ for more details.

Harbormaster completed remote builds in B30861: Diff 29809.Aug 18 2022, 3:10 PM

vlorentz requested review of this revision.Aug 18 2022, 3:10 PM

We don't use statsd namespaces, which use dots in metric names and aren't really compatible with the way we set up the prometheus statsd exporter.

This revision now requires changes to proceed.Aug 18 2022, 4:28 PM

we do in loaders: https://forge.softwareheritage.org/source/swh-loader-core/browse/master/swh/loader/core/loader.py$135

Meh. Seems like some default from prometheus-statsd-exporter unexpectedly does the right thing then.

This revision is now accepted and ready to land.Aug 18 2022, 4:36 PM

Closed by commit rDSCRUB0cc86b0e45f0: Deduplicate statsd calls (authored by vlorentz). · Explain WhyAug 18 2022, 4:59 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSCRUB0cc86b0e45f0: Deduplicate statsd calls.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

swh/

scrubber/

storage_checker.py

27 lines

89%

Diff 29809

View Options

swh/scrubber/storage_checker.py

Deduplicate statsd callsClosedPublicActions