RPC server: Do not log exceptions with 4xx HTTP status codes
ClosedPublic
Actions

Authored by vlorentz on Aug 5 2022, 4:30 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDCOREe8253c54f3bd: RPC server: Do not log exceptions with 4xx HTTP status codes

Summary

They are client errors, therefore it does not make sense to log them
as exceptions (which is only useful for debugging the server).

eg. P1417

Diff Detail

Repository

rDCORE Foundations and core functionalities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Aug 5 2022, 4:30 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 5 2022, 4:30 PM

vlorentz edited the summary of this revision. (Show Details)Aug 5 2022, 4:31 PM

Build is green

Patch application report for D8203 (id=29599)

Rebasing onto c824e4b66f...

Current branch diff-target is up to date.

Changes applied before test

commit e8253c54f3bddb1235805bdfc38f6f35c1e6bfc7
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Aug 5 16:30:15 2022 +0200

    RPC server: Do not log exceptions with 4xx HTTP status codes
    
    They are client errors, therefore it does not make sense to log them
    as exceptions (which is only useful for debugging the server).

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/460/ for more details.

Harbormaster completed remote builds in B30664: Diff 29599.Aug 5 2022, 4:32 PM

vlorentz requested review of this revision.Aug 5 2022, 4:32 PM