Page MenuHomeSoftware Heritage

Fix race condition between swh-storage and swh-storage-db.
ClosedPublic

Authored by vlorentz on Dec 14 2018, 3:03 PM.

Diff Detail

Repository
rCDFD Dockerfiles for developers
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Dec 14 2018, 3:03 PM
ardumont added inline comments.
dockerfiles/swh-storage/entrypoint.sh
31

indexer?

vlorentz updated this revision to Diff 2613.Dec 14 2018, 3:14 PM
  • Fix typo.
vlorentz marked 2 inline comments as done.Dec 14 2018, 3:14 PM
vlorentz added inline comments.
dockerfiles/swh-storage/entrypoint.sh
31

Woops :D

vlorentz updated this revision to Diff 2614.Dec 14 2018, 3:17 PM
vlorentz marked an inline comment as done.
  • Actually hide stderr

@douardda how do we usually deal with kind of issues?

ardumont accepted this revision.Dec 14 2018, 5:46 PM

Apparently some people use stuff like dockerize for that [1]

This sounds like a good and simple first approximation of what the other stuff do so why not ;)

[1] https://www.blog.labouardy.com/preventing-race-conditions-in-docker/

This revision is now accepted and ready to land.Dec 14 2018, 5:46 PM
vlorentz updated this revision to Diff 2639.Dec 17 2018, 11:06 AM
  • rebase/squash
This revision was automatically updated to reflect the committed changes.