Page MenuHomeSoftware Heritage

Fix crash of test_*_arbitrary when given objects with the same id
ClosedPublic

Authored by vlorentz on Fri, Aug 5, 11:40 AM.

Details

Summary

Replaces D8196, using Hypothesis' unique_by instead of manually trimming lists

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont accepted this revision.
ardumont added a subscriber: ardumont.

neat

This revision is now accepted and ready to land.Fri, Aug 5, 11:42 AM

Build is green

Patch application report for D8197 (id=29575)

Could not rebase; Attempt merge onto 4825f40a4f...

Updating 4825f40a..68b93a60
Fast-forward
 swh/storage/cassandra/storage.py   |  2 +-
 swh/storage/tests/storage_tests.py | 30 +++++++++++++++++++++++++-----
 2 files changed, 26 insertions(+), 6 deletions(-)
Changes applied before test
commit 68b93a608537478cc20a2f05f0f43a6d4b0d46e9
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Aug 5 11:27:08 2022 +0200

    Fix crash of test_*_arbitrary when given objects with the same id

commit 9b9eb282e83eb7ef8c11b7e6ca8d0164bf0dd141
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Aug 5 11:20:33 2022 +0200

    cassandra: Make origin_visit_status_get_random's interval consistent with postgresql
    
    The postgresql implementation uses '3 months', which is closer to 13 weeks
    than to 12 weeks.

commit 56f69e56b81c5abc28cb6e217e298ab95fb501cb
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Aug 5 11:18:46 2022 +0200

    Fix flakiness of test_origin_visit_status_get_random_nothing_found
    
    start is increased from 13 to 14, because 13 weeks is 91 days,
    ie. 30+31+30; so it is sometimes smaller than 3 months.
    
    This was only hit rarely because the number of visits was small,
    so this commit also increases the number of visits to make the
    test more likely to fail if it should actually fail.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1646/ for more details.