They are very noisy, and clients are expected to retry a few times
before re-raising the exception on their side.
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- rDSTOfc8905957923: Stop logging and sending postgresql timeouts to Sentry
Diff Detail
Diff Detail
- Repository
- rDSTO Storage manager
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Patch application report for D8187 (id=29552)
Could not rebase; Attempt merge onto 2205fa6e1f...
Updating 2205fa6e..fc890595 Fast-forward swh/storage/api/server.py | 18 +++++- swh/storage/cassandra/cql.py | 92 ++++++++++++--------------- swh/storage/tests/test_cassandra.py | 4 +- swh/storage/tests/test_cassandra_migration.py | 18 +++--- 4 files changed, 68 insertions(+), 64 deletions(-)
Changes applied before test
commit fc8905957923875d8ac3202809d145a1b8708044 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Thu Aug 4 16:02:47 2022 +0200 Stop logging and sending postgresql timeouts to Sentry They are very noisy, and clients are expected to retry a few times before re-raising the exception on their side. commit 1e7ede1828e7ba80733d3ac17f8d6c48bab2aeab Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Thu Aug 4 13:53:29 2022 +0200 Stop using `USE <keyspace>` with prepared statements This caused the following warning:
WARNING cassandra.protocol:libevreactor.py:361 Server warning: `USE <keyspace>` with prepared statements is considered to be an anti-pattern due to ambiguity in non-qualified table names. Please consider removing instances of `Session#setKeyspace(<keyspace>)`, `Session#execute("USE <keyspace>")` and `cluster.newSession(<keyspace>)` from your code, and always use fully qualified table names (e.g. <keyspace>.<table>). ``` This also prepends 'test' to the name of keyspaces used in tests, so they are guaranteed to start with an letter (starting with digits cause syntax errors in most statements).
commit 0aff46189a13e9f1d1d65418faa99ac1dc33d461
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Thu Aug 4 13:51:16 2022 +0200
cassandra: Simplify SELECT statement formatting
See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1641/ for more details.