Page MenuHomeSoftware Heritage
Differential D8150

Rename HashableObject to BaseHashableModel and make it a subclass of BaseModel
Needs ReviewPublic
Actions

Authored by vlorentz on Jul 21 2022, 12:44 PM.

Details

Reviewers
None
Group Reviewers
Reviewers
Summary

instead of a mix-in class.

A future commit will add a method implemented by both with different
signatures that mypy cannot unify yet.

Diff Detail

Repository
rDMOD Data model
Branch
evolve
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 30509
Build 47700: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 47699: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
1 msJenkins > .tox.py3-full.lib.python3.7.site-packages.swh.model.tests.test_model::test_object_type_is_final
def test_object_type_is_final(): object_types = set()
3 msJenkins > .tox.py3-full.lib.python3.7.site-packages.swh.model.merkle::swh.model.merkle.deep_update
1 msJenkins > .tox.py3-full.lib.python3.7.site-packages.swh.model.model::swh.model.model.TimestampWithTimezone._parse_offset_bytes
1 msJenkins > .tox.py3-full.lib.python3.7.site-packages.swh.model.model::swh.model.model.TimestampWithTimezone.offset_minutes
1 msJenkins > .tox.py3-full.lib.python3.7.site-packages.swh.model.swhids::swh.model.swhids.CoreSWHID
View Full Test Results (1 Failed · 864 Passed)

Event Timeline

vlorentz created this revision.Jul 21 2022, 12:44 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJul 21 2022, 12:44 PM
vlorentz added a child revision: D8151: [RFC] Add 'evolve' method to BaseModel objects.Jul 21 2022, 12:45 PM
swh-public-ci added a comment.Jul 21 2022, 12:46 PM

Build has FAILED

Patch application report for D8150 (id=29431)

Rebasing onto b872718ab4...

Current branch diff-target is up to date.
Changes applied before test
commit a2158edd4073887a36c9778dcc1b71c667e66866
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 21 12:42:42 2022 +0200

    Rename HashableObject to BaseHashableModel and make it a subclass of BaseModel
    
    instead of a mix-in class.
    
    A future commit will add a method implemented by both with different
    signatures that mypy cannot unify yet.

Link to build: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/490/
See console output for more information: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/490/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 21 2022, 12:46 PM
Harbormaster failed remote builds in B30509: Diff 29431!
vlorentz updated this revision to Diff 29435.Jul 21 2022, 12:57 PM

test_object_type_is_final: deduplicate traversal of diamonds

swh-public-ci added a comment.Jul 21 2022, 1:00 PM

Build is green

Patch application report for D8150 (id=29435)

Rebasing onto b872718ab4...

Current branch diff-target is up to date.
Changes applied before test
commit b867d22a904c41ac40c2e7629ecf7bfdcfa25c4b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 21 12:42:42 2022 +0200

    Rename HashableObject to BaseHashableModel and make it a subclass of BaseModel
    
    instead of a mix-in class.
    
    A future commit will add a method implemented by both with different
    signatures that mypy cannot unify yet.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/492/ for more details.

Harbormaster completed remote builds in B30512: Diff 29435.Jul 21 2022, 1:00 PM
vlorentz requested review of this revision.Jul 21 2022, 1:00 PM

Revision Contents
Changeset List

PathSize
swh/
model/
16 lines

Diff 29431

View Options

swh/model/model.py

Loading...
About · Developer information · Legal