Page MenuHomeSoftware Heritage

Rename HashableObject to BaseHashableModel and make it a subclass of BaseModel
Needs ReviewPublic

Authored by vlorentz on Thu, Jul 21, 12:44 PM.

Details

Reviewers
None
Group Reviewers
Reviewers
Summary

instead of a mix-in class.

A future commit will add a method implemented by both with different
signatures that mypy cannot unify yet.

Diff Detail

Event Timeline

Build has FAILED

Patch application report for D8150 (id=29431)

Rebasing onto b872718ab4...

Current branch diff-target is up to date.
Changes applied before test
commit a2158edd4073887a36c9778dcc1b71c667e66866
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 21 12:42:42 2022 +0200

    Rename HashableObject to BaseHashableModel and make it a subclass of BaseModel
    
    instead of a mix-in class.
    
    A future commit will add a method implemented by both with different
    signatures that mypy cannot unify yet.

Link to build: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/490/
See console output for more information: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/490/console

Harbormaster returned this revision to the author for changes because remote builds failed.Thu, Jul 21, 12:46 PM
Harbormaster failed remote builds in B30509: Diff 29431!

test_object_type_is_final: deduplicate traversal of diamonds

Build is green

Patch application report for D8150 (id=29435)

Rebasing onto b872718ab4...

Current branch diff-target is up to date.
Changes applied before test
commit b867d22a904c41ac40c2e7629ecf7bfdcfa25c4b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 21 12:42:42 2022 +0200

    Rename HashableObject to BaseHashableModel and make it a subclass of BaseModel
    
    instead of a mix-in class.
    
    A future commit will add a method implemented by both with different
    signatures that mypy cannot unify yet.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/492/ for more details.