Page MenuHomeSoftware Heritage

Add minimum version requirement for pytest
ClosedPublic

Authored by vlorentz on Jul 7 2022, 12:35 PM.

Details

Summary

Using older versions works for passing tests, but assertion failures
cause a very obscure traceback on teardown

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D8095 (id=29207)

Could not rebase; Attempt merge onto 3d80435710...

Updating 3d804357..58706c38
Fast-forward
 requirements-test.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Changes applied before test
commit 58706c38e044f514b519a84e3fd84d5bc7f6bba1
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 7 12:35:35 2022 +0200

    Add minimum version requirement for pytest
    
    Using older versions works for passing tests, but assertion failures
    cause a very obscure traceback on teardown

commit 1402ec5e7c1521def7804422afc86022010db777
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 7 11:51:31 2022 +0200

    Add missing dependency on types-cryptography
    
    For some reason it is not an issue within tox; but mypy has been
    bugging me about this for a while.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1911/ for more details.

This revision is now accepted and ready to land.Jul 7 2022, 2:53 PM